[BusyBox 0001088]: "wget" can't fetch ftp files with PASV mode (with patch)

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=1088 
====================================================================== 
Reported By:                rockeychu
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1088
Category:                   Networking Support
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             11-09-2006 19:13 PST
Last Modified:              11-21-2006 03:06 PST
====================================================================== 
Summary:                    "wget" can't fetch ftp files with PASV mode (with
patch)
Description: 
When fetch ftp files with PASV mode, wget always reports following error:
    wget: invalid number 'XXX).'
where XXX is port number.

The simple solution is as following (or trimming PASV's port number
endings ').' ):

Index: libbb/xatol.c
===================================================================
--- libbb/xatol.c       (revision 16525)
+++ libbb/xatol.c       (working copy)
@@ -79,8 +79,8 @@

        /* Note: trailing space is an error.
           It would be easy enough to allow though if desired. */
-       if (*e)
-               goto inval;
+       //if (*e)
+       //      goto inval;
        /* Finally, check for range limits. */
        if (r >= lower && r <= upper)
                return r;

====================================================================== 

---------------------------------------------------------------------- 
 vda - 11-21-06 03:06  
---------------------------------------------------------------------- 
Yeah, yeah, let's kill error checks for everybody, just because we are too
lazy to find the bug...

Fixed correctly in rev 16603. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-09-06 19:13  rockeychu      New Issue                                    
11-09-06 19:13  rockeychu      Status                   new => assigned     
11-09-06 19:13  rockeychu      Assigned To               => BusyBox         
11-21-06 03:06  vda            Status                   assigned => closed  
11-21-06 03:06  vda            Note Added: 0001749                          
======================================================================